Skip to content

fix: More heading levels so RNs resolve links #1228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2025
Merged

fix: More heading levels so RNs resolve links #1228

merged 1 commit into from
Jun 19, 2025

Conversation

@mikemckiernan
Copy link
Collaborator

@mikemckiernan mikemckiernan commented Jun 12, 2025 •
edited
Loading

Description

We need to increase the number of heading levels that are possible targets so that the RNs can link to the headings.

This fixes a goof in the RNs where the "Added the rails.output.apply_to_reasoning_traces field" bullet did not end with a link at all.

Related Issue(s)

Checklist

  • I've read the CONTRIBUTING guidelines.
  • I've updated the documentation if applicable.
  • I've added tests if applicable.
  • @mentions of the person or team responsible for reviewing proposed changes.

@mikemckiernan
fix: More heading levels so RNs resolve links
0176574 
Signed-off-by: Mike McKiernan <mmckiernan@nvidia.com>
@mikemckiernan mikemckiernan self-assigned this Jun 12, 2025
@mikemckiernan mikemckiernan added the documentation Improvements or additions to documentation label Jun 12, 2025
@mikemckiernan mikemckiernan added this to the v0.15.0 milestone Jun 12, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 12, 2025

Documentation preview

https://nvidia.github.io/NeMo-Guardrails/review/pr-1228

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.65%. Comparing base (5a4733f) to head (0176574).
⚠️ Report is 62 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1228   +/-   ##
========================================
  Coverage    68.65%   68.65%           
========================================
  Files          161      161           
  Lines        15978    15978           
========================================
  Hits         10969    10969           
  Misses        5009     5009
Flag Coverage Δ
python 68.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mikemckiernan mikemckiernan requested a review from cparisien June 12, 2025 19:40
@mikemckiernan mikemckiernan requested a review from tgasser-nv June 12, 2025 19:54
@Pouyanpi Pouyanpi self-requested a review June 19, 2025 12:47
@Pouyanpi Pouyanpi merged commit 5f9974a into NVIDIA-NeMo:develop Jun 19, 2025
38 of 63 checks passed
@Pouyanpi Pouyanpi modified the milestones: v0.15.0, v0.14.0, v0.14.1 Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pouyanpi Pouyanpi Pouyanpi approved these changes

@cparisien cparisien cparisien approved these changes

@tgasser-nv tgasser-nv Awaiting requested review from tgasser-nv

Assignees

@mikemckiernan mikemckiernan

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

v0.14.1

Development

Successfully merging this pull request may close these issues.

4 participants

@mikemckiernan @codecov-commenter @Pouyanpi @cparisien